Skip to content

[Refactor] Derive onboarding order from one canonical flow - #1394

Merged
mrubens merged 1 commit into
developfrom
refactor/onboarding-step-order-3f962516rpzk9
Aug 16, 2026
Merged

[Refactor] Derive onboarding order from one canonical flow#1394
mrubens merged 1 commit into
developfrom
refactor/onboarding-step-order-3f962516rpzk9

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Created by Roomote. View the task or mention @roomote-roomote for follow-up asks.

What changed

  • Kept the setup step definitions as the single canonical flow.
  • Derived the email/password sequence through a typed policy that moves only the communication setup block after source control.
  • Added focused coverage that preserves both complete step orders and verifies they contain the same canonical steps.

Why this change was made

PR #1331 introduced a second complete setup sequence to support a different provider order for email/password users. Keeping two full arrays made future step additions and renames vulnerable to auth-mode-specific drift.

Impact

There is no intended user-facing behavior change. Email/password users retain the reordered provider flow, communication-auth users retain the canonical flow, and future setup steps now enter both modes from one definition.

@roomote-community

roomote-community Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed bf7bc35

@mrubens
mrubens marked this pull request as ready for review August 16, 2026 12:35
@mrubens
mrubens merged commit 6f745b1 into develop Aug 16, 2026
17 checks passed
@mrubens
mrubens deleted the refactor/onboarding-step-order-3f962516rpzk9 branch August 16, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants