Skip to content

[Fix] Review notifications omit response buttons in web tasks - #1443

Merged
daniel-lxs merged 3 commits into
developfrom
fix/review-notification-buttons-0zxujhpxnw2v8
Aug 28, 2026
Merged

[Fix] Review notifications omit response buttons in web tasks#1443
daniel-lxs merged 3 commits into
developfrom
fix/review-notification-buttons-0zxujhpxnw2v8

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Publish actionable review offers into standard coding-task history and render the shared Resolve, Auto-resolve, and Dismiss control in the web transcript.
  • Route standard-task actions through the canonical destination-scoped claim, release, and idempotent web follow-up infrastructure merged in #1808.
  • Retire outstanding standard-task offers when a typed reply supersedes them, persist handled states across reloads, and keep legacy auto-resolve compatibility writes scoped to the source-control provider.
  • Suppress the inner transcript control in Fast sessions so [Fix] Fast sessions omit pull request review actions #1808's existing action card remains the only Fast action surface.

Why this change was made

#1808 now owns the shared action types, Fast-session UI, canonical lifecycle, and web retry/dispatch behavior. This refresh removes the stale draft's duplicated infrastructure and preserves only the still-missing standard coding-task transcript integration.

Impact

People using standard web tasks can act on pull-request review feedback without typing a follow-up. Fast sessions keep their existing #1808 experience, duplicate or late clicks remain idempotent, unavailable dispatches can be retried, and cross-provider pull-request collisions stay isolated.

Screenshots

Final post-#1808 standard coding-task transcript with one Resolve, Auto-resolve, and Dismiss action group

@roomote-community

roomote-community Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

No new code issues found. See task

  • apps/web/src/trpc/commands/sandbox-session/index.ts:422 - Auto-resolve is scoped to the source-control provider.
  • apps/web/src/trpc/commands/sandbox-session/index.ts:203 - A lost duplicate-action claim overwrites the actual terminal transcript status with stale.
  • apps/web/src/trpc/commands/sandbox-session/index.ts:220 - Accepting one web offer no longer globally dismisses other pending review offers for the task.
  • apps/web/src/trpc/commands/sandbox-session/index.ts:227 - An unavailable Resolve dispatch reopens the web-only delivery for retry.

Reviewed ce23a16

Comment thread apps/web/src/trpc/commands/sandbox-session/index.ts Outdated
@roomote-roomote
roomote-roomote Bot force-pushed the fix/review-notification-buttons-0zxujhpxnw2v8 branch 2 times, most recently from d1684a7 to f39c669 Compare August 28, 2026 22:12
Comment thread apps/web/src/trpc/commands/sandbox-session/index.ts Outdated
Comment thread apps/web/src/trpc/commands/sandbox-session/index.ts Outdated
Comment thread apps/web/src/trpc/commands/sandbox-session/index.ts Outdated
@roomote-roomote
roomote-roomote Bot force-pushed the fix/review-notification-buttons-0zxujhpxnw2v8 branch from f39c669 to 591df90 Compare August 28, 2026 22:55
@roomote-roomote
roomote-roomote Bot force-pushed the fix/review-notification-buttons-0zxujhpxnw2v8 branch from 591df90 to 77d64ea Compare August 28, 2026 23:15
@daniel-lxs
daniel-lxs marked this pull request as ready for review August 28, 2026 23:51
@daniel-lxs
daniel-lxs merged commit ab1b4d3 into develop Aug 28, 2026
16 of 17 checks passed
@daniel-lxs
daniel-lxs deleted the fix/review-notification-buttons-0zxujhpxnw2v8 branch August 28, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant