[Fix] Keep the Fast transcript's working indicator up until the turn ends - #2039
Open
mrubens wants to merge 1 commit into
Open
[Fix] Keep the Fast transcript's working indicator up until the turn ends#2039mrubens wants to merge 1 commit into
mrubens wants to merge 1 commit into
Conversation
…ends The Thinking indicator cleared on the first visible non-user message of any kind, tool events included. Until integrations became on demand the first event was almost always the acknowledgement, so this went unnoticed; now a lookup can come first and the transcript went quiet with nothing said yet, and it always went quiet after any mid-turn tool call. The session's responding lease already tracks the real turn and now ends at the closeout, so show a Working indicator whenever it is active after visible output.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the model makes a tool call, the Fast transcript looks idle even though the turn is still running. The "Thinking" indicator is driven by "no visible non-user message since the user's message," and a tool event counts as visible, so it cleared on the first tool call. Until #2031 the first event was almost always the acknowledgement (integration calls were gated behind it), which hid this; now
find_integration_toolscan run first, and the transcript goes quiet with nothing said. It also always went quiet after any mid-turn tool call, and the trailing post-closeout request that #2030 removed used to blur the end of the turn.Change
The session's responding lease is already the authority for "the turn is running" (set at turn start, cleared at turn end, which #2030 moved to the closeout). When it is active after visible output, the transcript shows a "Working" indicator in the same slot; "Thinking" is unchanged for the no-output-yet case. The existing stale-lease guard still applies: the client only trusts
responding: truewhen it arrives with new output, so a reconnect with a leftover lease does not show a false indicator.Verification
New transcript test: follow-up shows Thinking, a streamed tool event with the lease active switches it to Working, and the closeout with the lease released clears it. Transcript client suite (30) passes; typecheck and lint clean.