[Fix] Task deletion no longer leaks artifacts after storage failures - #2186
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
[Fix] Task deletion no longer leaks artifacts after storage failures#2186roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 4, 2026 05:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Task deletion now aborts when artifact object deletion throws or reports failed objects. The transaction retains task and artifact metadata instead of committing a soft-deleted task whose remaining object-store keys can no longer be retried.
Focused regression coverage verifies that both reported batch failures and thrown storage errors occur before any artifact-row, task, parallel-count, or session mutation. The successful deletion path remains unchanged.
Why this change was made
The previous best-effort path deleted every
taskArtifactsrow even when S3 returned errors. That erased the only durable mapping to failed object keys and could permanently leak stored artifacts.Impact
Users can retry task deletion after a transient or partial storage failure without leaving unreachable objects behind. The targeted task-deletion suite passes all 6 tests, and the web package type-check and changed-file formatting checks pass.
Related PRs