[Feat] Add recognizable robot icons to tasks - #2219
Conversation
|
No code issues found. See task
Reviewed 2ea8349 |
|
Fixed the standalone task workspace context mismatch in commit 77918ab: live and historical transcripts now consume the same Session-seeded robot assignment as the task header. Focused tests and the repository pre-push checks pass. |
|
Implemented Bruno's Avatar and centering feedback in commit c0b3cfa. Every placement now uses the shared |
| return ( | ||
| <Avatar | ||
| imageUrl={getTaskRobotIconPath(iconId)} | ||
| size="sm" |
There was a problem hiding this comment.
TaskRobotIcon now hard-codes the 24px sm avatar, so it cannot retain the sizing required by its different hosts. In particular, task launch cards were designed with size-11 and ACP tool rows with size-4; both call sites lost those sizes in this commit, leaving an undersized card avatar and a 24px tool-row icon that increases the row height. Keep a className or size override on this wrapper and pass the appropriate dimensions at each call site.
There was a problem hiding this comment.
Not changing this sizing: Bruno explicitly requested that every task robot placement render through the shared Avatar with size="sm", replacing the prior per-host dimensions. The updated task card, nested header, standalone header, and tool row were visually verified at that shared size, including centered regenerated artwork.
|
@roomote-roomote can you resolve conflicts, address feedback, and take a screenshot of what this looks like? |
I’ll resolve the PR conflicts against the current base, verify the remaining feedback is addressed without undoing the requested I’m resolving the conflicts, addressing the current feedback while retaining Working on a live preview, reply with @-mention or use the web app. |
…-icons-3si8i2mxtqdxn
|
Resolved the current |
What changed
Avatarcomponent atsmsize.developSession panel-controller refactor while retaining the Session-level task robot context.The supplied image resolves to an 11x11 grid rather than the described 10x10 grid. The generator intentionally takes the first 100 cells in row-major order and keeps the original sheet as the reproducible source of truth.
Why this change was made
Delegated work is easier to follow when a task has one recognizable visual identity everywhere it appears. Shared Avatar rendering aligns task robots with existing user-avatar behavior, while source-level centering keeps every drawing balanced without host-specific positioning.
Impact
Users can visually track the same task from Session conversation activity into its nested panel and full task workspace. All placements use the same compact circular Avatar treatment, all 100 assets are centered and safe within that circular crop, and stable assignment behavior is unchanged. The branch is merged with current
developwithout discarding its extracted Session workspace controller.Verification covered the integrated Session conflict surface (4 files, 105 tests), relevant task robot client suites (8 files, 132 tests), mapping and generated-asset suites (2 files, 7 tests), full web TypeScript, and the repository pre-push oxlint, residual lint, fast typecheck, and knip gates. Repeated generation produced identical hashes. Pixel auditing confirmed 100 96px assets, at least 2px canvas clearance, and visual-mass center offsets no greater than 4.1px (about 1px at rendered
smsize); all-100 square and circular contact-sheet inspections found no clipping, bleed, centering defects, or inappropriate scale outliers. Browser proof is not attached because the proof workflow exceeded its shared five-minute deadline.