Make hosted compute provisioning non-blocking#307
Merged
Conversation
Contributor
|
No new code issues found. See task Since the last review, the only in-scope change is commit Non-blocking note (unchanged from the initial review): the persisted task failure message points to "Settings → Sandboxes" while the onboarding retry buttons navigate to the compute-config step — slightly inconsistent recovery guidance. Reviewed 63bcc47 |
…-hosted-compute-provisioning # Conflicts: # apps/web/src/trpc/commands/compute/compute-provisioning.test.ts # apps/web/src/trpc/commands/setup-new/index.test.ts
mrubens
marked this pull request as ready for review
July 13, 2026 23:51
8 tasks
brunobergher
pushed a commit
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Hosted worker artifacts are deployment-wide, but first-time provisioning previously blocked the onboarding flow. This lets administrators continue configuring source control, repositories, and environments while the selected provider is prepared, without silently switching providers.
Validation
git diff --check