[Fix] Automation labels show "Codeql Triage" instead of "CodeQL Triage"#455
Merged
Merged
Conversation
Humanize codeql_triage as "CodeQL Triage" instead of "Codeql Triage".
Contributor
Author
|
0 issues outstanding.
|
Contributor
Author
|
Fixed the token-override review issue.
No review threads to resolve (finding was on the top-level summary only). Left CLA alone as requested. |
Use a Map for token overrides so formatAutomationLabel never treats Object.prototype properties as brand-casing mappings.
mrubens
marked this pull request as ready for review
July 16, 2026 22:40
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 16, 2026 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal polish from Slack feedback (no tracked issue).
Why this PR exists
What changed
formatAutomationLabelnow spells the CodeQL brand correctly, socodeql_triagesurfaces as CodeQL Triage (not Codeql Triage) anywhere automation keys are humanized (task filters, analytics labels, attribution).Token overrides use a
Mapso unconstrained token lookups never accidentally pick upObject.prototypekeys such asconstructorortoString.How it was tested
formatAutomationLabel('codeql_triage') === 'CodeQL Triage'constructor→Constructor)pnpm --filter @roomote/web exec vitest run src/lib/task-creator-filter.test.ts(12 passed)Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset