[Fix] OpenRouter Connect fails when self-hosted app URL is loopback#465
Merged
Merged
Conversation
Use getPublicAppUrl so self-hosted fleets with a loopback R_APP_URL still advertise a browser-reachable OpenRouter callback and setup redirect.
Contributor
Author
|
No new code issues found. See task
Reviewed 81cd3aa |
Contributor
Author
|
Fixed the callback URL construction.
Commit: 81cd3aa |
Avoid string-concat double slashes when R_PUBLIC_URL ends with /.
mrubens
marked this pull request as ready for review
July 17, 2026 02:58
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 17, 2026 02:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal setup OAuth bug report from Slack / task: OpenRouter connect used loopback
R_APP_URLfor callback_url while self-hosted fleets publish a separate public edge viaR_PUBLIC_URL.Why this PR exists
What changed
OpenRouter setup OAuth now prefers
R_PUBLIC_URL(falling back toR_APP_URL) for:callback_urlsent to OpenRouter/setup?step=env-varsThe callback URL is built with
new URL('/api/openrouter-oauth/callback', publicAppUrl)so a public base that ends in/does not produce a double-slash path (which would miss the PKCE verifier cookie).A shared
getPublicAppUrl()helper matches the existing GitLab/Bitbucket OAuth behavior, and route tests cover public URL set vs unset (including trailing-slash bases).Self-hosted admins who click Connect OpenRouter on the public edge no longer have OpenRouter send them to a loopback redirect URI.
How it was tested
getPublicAppUrlget-callback-hosttests still pass after reusing the helperChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset