Skip to content

[Fix] Discord follow-ups show raw prompt wrappers in the task transcript#561

Merged
mrubens merged 1 commit into
developfrom
fix/strip-discord-transcript-wrappers-3vixh7zkpiyt9
Jul 18, 2026
Merged

[Fix] Discord follow-ups show raw prompt wrappers in the task transcript#561
mrubens merged 1 commit into
developfrom
fix/strip-discord-transcript-wrappers-3vixh7zkpiyt9

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

Internal follow-up from Discord/transcript display.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Discord follow-up prompts include structural wrappers (replying_to, discord_turn_policy, thread_context, communication_message). The task transcript was showing that raw markup instead of only the user's words.

normalizeTranscriptUserText now strips those Slack-parity prefixes the same way it already handles bare communication_message and Slack turns, so the UI shows just the user message body.

How it was tested

  • Extended unit coverage in packages/types/src/__tests__/acp.test.ts for Discord prefixes (with and without thread_context), policy-only prefixes, and HTML-escaped wrappers
  • pnpm --filter @roomote/types exec vitest run src/__tests__/acp.test.ts (77 tests passed)
  • Pre-push: oxlint, residual lint, check-types:fast, knip

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-roomote

roomote-roomote Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed e2fa7e2

@mrubens
mrubens marked this pull request as ready for review July 18, 2026 19:46
@mrubens
mrubens merged commit 868901c into develop Jul 18, 2026
17 checks passed
@mrubens
mrubens deleted the fix/strip-discord-transcript-wrappers-3vixh7zkpiyt9 branch July 18, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant