[Refactor] Split broker adapter lifecycle responsibilities#723
Merged
Conversation
Contributor
Author
mrubens
marked this pull request as ready for review
July 23, 2026 16:42
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 23, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Split the Roomote broker adapter's signed HTTP transport and command-stream lifecycle handling into focused collaborators. The public compute-provider client contract, broker request error export, and existing sandbox, snapshot, and file-write behavior remain unchanged.
Why this change was made
The broker adapter had become a second owner of lifecycle-heavy execution logic alongside the direct Modal adapter. Isolating broker signing and NDJSON command handling makes provider behavior easier to evolve and test without coupling it to the client facade.
Impact
No user-visible behavior change is intended. Broker command execution retains Modal-compatible output delivery, detached-process reconciliation, and exit polling while the adapter is substantially easier to maintain.