Skip to content

RK-12380 - Added a dev container#43

Merged
Urook merged 2 commits intomasterfrom
add-dev-container
May 24, 2022
Merged

RK-12380 - Added a dev container#43
Urook merged 2 commits intomasterfrom
add-dev-container

Conversation

@Urook
Copy link
Contributor

@Urook Urook commented May 17, 2022

Added a dev container

@Urook
Copy link
Contributor Author

Urook commented May 17, 2022

Github Enforcer opened Task: RK-12380

@sonariorobot sonariorobot changed the title Added a dev container RK-12380 - Added a dev container May 17, 2022
Copy link

@EliRookout EliRookout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Dockerfile overrides the devcontainer.json? cause it seems like there are different values for the same arguments in those files. For example INSTALL_MAVEN and INSTALL GRADLE have true in devcontainer.json but false in the Dockerfile (it's confusing)

@Urook
Copy link
Contributor Author

Urook commented May 18, 2022

Does the Dockerfile overrides the devcontainer.json? cause it seems like there are different values for the same arguments in those files. For example INSTALL_MAVEN and INSTALL GRADLE have true in devcontainer.json but false in the Dockerfile (it's confusing)

It should override them

@Urook
Copy link
Contributor Author

Urook commented May 18, 2022

@EliRookout Should I change it in Dockerfile for clarification's case?

@Urook Urook requested a review from EliRookout May 18, 2022 14:49
@EliRookout
Copy link

@EliRookout Should I change it in Dockerfile for clarification's case?

I think you should modify the devcontainer.json to have the same values as in the Dockerfile it would be less confusing

@Urook
Copy link
Contributor Author

Urook commented May 23, 2022

@EliRookout Done

@Urook Urook merged commit b3ed56c into master May 24, 2022
@Urook Urook deleted the add-dev-container branch May 24, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants