Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2023-10-27 - A11y & Focus Enhancements
**Learning:** Adding `focus-visible` classes to interactive elements like custom buttons or links significantly improves keyboard accessibility without degrading the mouse/touch experience. Simple hover transitions (like a subtle scale) boost the premium feel.
**Action:** Always verify custom interactive components have clear focus rings (`focus-visible:ring-2 focus-visible:ring-primary focus-visible:ring-offset-2 ring-offset-background`). Ensure semantic tags like `<nav>` have `aria-label`s for screen readers.
6 changes: 3 additions & 3 deletions src/components/portfolio/TerminalTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,9 @@ export function TerminalTab() {
rel="noopener noreferrer"
aria-label={`Connect via ${label}`}
onClick={() => sendTelegramNotification("Clicked Contact Channel (Terminal)", { channel: label, url: href })}
className="bento-card group flex items-center gap-3 !p-3 hover:border-primary/60 sm:gap-4 sm:!p-4"
className="bento-card group flex items-center gap-3 !p-3 hover:border-primary/60 sm:gap-4 sm:!p-4 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-primary focus-visible:ring-offset-2 ring-offset-background"
>
<span className="grid h-9 w-9 shrink-0 place-items-center rounded-lg bg-primary/10 text-primary sm:h-10 sm:w-10">
<span className="grid h-9 w-9 shrink-0 place-items-center rounded-lg bg-primary/10 text-primary sm:h-10 sm:w-10 transition-transform duration-300 group-hover:scale-110">
<Icon className="h-4 w-4 sm:h-5 sm:w-5" />
</span>
<div className="min-w-0 flex-1">
Expand All @@ -291,7 +291,7 @@ export function TerminalTab() {
navigator.clipboard.writeText(value);
toast({ title: "Copied", description: value });
}}
className="shrink-0 text-muted-foreground transition-colors hover:text-primary"
className="shrink-0 text-muted-foreground transition-colors hover:text-primary focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-primary rounded-sm"
aria-label="Copy email"
>
<Copy className="h-4 w-4" />
Expand Down
2 changes: 1 addition & 1 deletion src/components/portfolio/TopNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const TopNav = memo(function TopNav({ active, onChange, onOpenPalette }:
</button>

{/* Tabs Navigation */}
<nav className="flex items-center gap-0.5 sm:gap-1 rounded-full bg-secondary/40 p-0.5 sm:p-1 shrink-0">
<nav aria-label="Main Navigation" className="flex items-center gap-0.5 sm:gap-1 rounded-full bg-secondary/40 p-0.5 sm:p-1 shrink-0">
{tabs.map((t) => {
const isActive = active === t.id;
return (
Expand Down