lseek returned 1179520, not 1179520 - regression from CVE fixes

[sylvain-ilm]

Hi,

Since rsync 3.4.1 on a FreeBSD 14 system, I've got :

>f.st....... data/Sauvegarde/local/DB/psql/databases/225367/236044.dat
rsync: [receiver] lseek returned 1179520, not 1179520: No error: 0 (0)
rsync: [receiver] write failed on "/data/Sauvegarde/data/std/data/Sauvegarde/local/DB/psql/databases/225367/236044.dat": No error: 0 (0)
rsync error: error in file IO (code 11) at receiver.c(381) [receiver=3.4.1]
rsync: [generator] write error: Broken pipe (32)
rsync error: error in socket IO (code 10) at io.c(849) [generator=3.4.1]
rsync: [receiver] write error: Broken pipe (32)

Sometimes values do differ :

rsync: [receiver] lseek returned 1118264, not 1121456: No error: 0 (0)
rsync: [receiver] write failed on "/data/Sauvegarde/data/std/data/Sauvegarde/local/DB/psql/databases/225367/249725.dat": No error: 0 (0)

Reverting the receiver to 3.3.0 does fix the problem.

Here's the command line :

rsync -aviz --numeric-ids --stats --timeout 600 --exclude logs --exclude Cache --partial --inplace --no-whole-file -b --backup-dir /tmp/rsync_backup-dir6352252118121511819 --delete-delay --delete-excluded --max-delete 10000 --copy-dest=/data/Sauvegarde/data/std/.zfs/snapshot/2025-01-23T03:00:00Z fqdn::std/ /data/Sauvegarde/data/std

Cheers

[agostonbarna]

This error seems to be triggered by the rsync --inplace flag.

[tbsmark86]

Same here on Ubuntu 22.04 Version (3.2.7-0ubuntu0.22.04.4)
In my case I have a daemon running and almost every time the client uses --inplace and --backup together it happens. Seems like only logfiles (or other append-only-stuff) is affected.

I also get a lot of these:

   WARNING: <file> failed verification -- update retained (will try again).

before the lseek error:

   rsync: [receiver] lseek returned 2438432, not 2438432: Invalid argument
   rsync: [receiver] write failed on "<file>" (in backup): Invalid argument (22)
   rsync error: error in file IO (code 11) at receiver.c(381) [receiver=3.2.7]
   rsync error: error in file IO (code 11) at io.c(1701) [generator=3.2.7]

Reverting to the old (ubuntu) binary resolves it.

[tridge]

thanks for the report! This was fixed in master by #913, closing