Skip to content

TextStyle completeness: add strikethrough/overline/blink with merge+encoding hardening#66

Merged
RtlZeroMemory merged 8 commits into
mainfrom
create-textstyle-completeness
Feb 18, 2026
Merged

TextStyle completeness: add strikethrough/overline/blink with merge+encoding hardening#66
RtlZeroMemory merged 8 commits into
mainfrom
create-textstyle-completeness

Conversation

@RtlZeroMemory

@RtlZeroMemory RtlZeroMemory commented Feb 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • add strikethrough, overline, and blink to TextStyle and style presets
  • extend ResolvedTextStyle and mergeTextStyle to merge/inherit all 8 boolean attrs with tri-state semantics
  • expand BASE_BOOL_STYLE_CACHE keyspace handling for 8 attrs (65536 direct-addressed entries)
  • update drawlist style encoding in v1/v2 builders to pack attrs on bits 0..7 (strikethrough=5, overline=6, blink=7)
  • include new attrs in runtime text style equality checks used by commit diffing
  • update partial drawlist style-key test helper to track new attrs
  • bump vendored Zireael engine to v1.3.5 (d551156) so backend SGR emission supports strikethrough, overline, and blink

Tests

  • add and expand deterministic style tests:
    • packages/core/src/widgets/__tests__/style.attributes.test.ts
    • packages/core/src/widgets/__tests__/style.merge.test.ts
    • packages/core/src/drawlist/__tests__/builder.style-encoding.test.ts
  • exhaustive attr encoding checks for all 256 boolean masks across drawlist builders
  • merge/cache correctness checks across all 8 attrs (inherit/override/deep chains/cache separation)
  • full repo validation: npm run lint, npm run typecheck, npm run build, node scripts/run-tests.mjs

Docs

  • update docs/guide/styling.md
  • add docs/guide/text-style-internals.md with bit layout, merge semantics, cache details, and backend support status

Why

This closes style-pipeline gaps for missing text attributes from definition through merge, drawlist encoding, and backend SGR emission, with broad regression coverage for future changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b51c648fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/core/src/drawlist/builder_v1.ts
@RtlZeroMemory
RtlZeroMemory merged commit 6074208 into main Feb 18, 2026
18 checks passed
@RtlZeroMemory
RtlZeroMemory deleted the create-textstyle-completeness branch February 19, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant