405 fix issues in stan

[apphp]

No description provided.

[Copilot]

Pull request overview

This PR updates the NeuralNet subsystem and related consumers/tests to address PHPStan findings and ongoing refactors (notably around Network/FeedForward types and NDArray usage), plus a few targeted robustness tweaks.

Changes:

• Refactors NeuralNet “Network” usage: introduces Networks\Base\Contracts\Network, updates snapshots/tests to use Networks\FeedForward\FeedForward, and removes the old Networks\Network class.
• Updates several learners (classifiers/regressors) and tests to instantiate FeedForward instead of Network.
• Adds a handful of correctness/robustness adjustments (RBX checksum parsing validation, CommitteeMachine empty-experts guard, doc/type tweaks, and snapshot expectation updates).

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tests/NeuralNet/Snapshots/SnapshotTest.php	Updates snapshot tests to use the new Networks\FeedForward\FeedForward and contract imports.
tests/NeuralNet/SnapshotTest.php	Switches to constructing NeuralNet\FeedForward in snapshot test.
tests/NeuralNet/Networks/NetworkTest.php	Updates imports/instantiation to test the new Networks\FeedForward\FeedForward against the new Networks\Base\Contracts\Network.
tests/NeuralNet/NetworkTest.php	Switches instantiation to NeuralNet\FeedForward (legacy path).
tests/NeuralNet/Layers/Swish/SwishTest.php	Adjusts expected float output in Swish backprop test.
tests/NeuralNet/FeedForwards/FeedForwardTest.php	Updates imports and assertions to reflect new Networks\FeedForward\FeedForward type hierarchy.
src/Serializers/RBX.php	Adds checksum format validation during RBX deserialization.
src/Regressors/Ridge.php	Adjusts NumPower usage (transpose signature and aliasing).
src/Regressors/MLPRegressor.php	Switches internal network type/docs from Network to FeedForward.
src/Regressors/Adaline.php	Switches internal network type/docs from Network to FeedForward.
src/NeuralNet/Snapshots/Snapshot.php	Updates snapshot to depend on the new Networks\Base\Contracts\Network.
src/NeuralNet/Optimizers/Adam/Adam.php	Adds a local phpdoc hint for $zeros NDArray type.
src/NeuralNet/Networks/Network.php	Deletes the old Networks\Network class.
src/NeuralNet/Networks/FeedForward/FeedForward.php	Moves/updates FeedForward to implement the new Network contract; adds sample-normalization scaffolding in infer().
src/NeuralNet/Networks/Base/Contracts/Network.php	Introduces a new NDArray-oriented Network contract interface.
src/NeuralNet/Network.php	Converts Rubix\ML\NeuralNet\Network into a minimal interface (layers-only).
src/NeuralNet/Layers/Multiclass/Multiclass.php	Tightens PHPDoc return type for back() to a shaped array.
src/NeuralNet/Layers/Base/Contracts/Parametric.php	Fixes PHPDoc types for parameters/restore signatures.
src/NeuralNet/FeedForward.php	Updates legacy FeedForward to implements Network (instead of extending).
src/CommitteeMachine.php	Adds an explicit guard when calling type() on an empty expert set.
src/Classifiers/SoftmaxClassifier.php	Switches internal network type/docs from Network to FeedForward.
src/Classifiers/MultilayerPerceptron.php	Switches internal network type/docs from Network to FeedForward.
src/Classifiers/LogisticRegression.php	Switches internal network type/docs from Network to FeedForward.
phpstan-baseline.neon	Updates PHPStan baseline (removing some ignores, adding others).
CHANGELOG.md	Adds changelog entries for NDArray conversion and Network interface changes.

Comments suppressed due to low confidence (2)

src/NeuralNet/Networks/FeedForward/FeedForward.php:101

• $normalizeSamples is always initialized to false and there is no public API to enable it, so the normalization/reshape branch in infer() (and the normalizeSamples() helper) is currently dead code. Either remove the flag+branch, or make normalization configurable (constructor param/setter) and ensure it’s applied consistently in both infer() and training paths (roundtrip()), not just inference.
  tests/NeuralNet/Networks/NetworkTest.php:26
• #[CoversClass(Network::class)] now refers to the Networks\Base\Contracts\Network interface (due to the import change), but this test exercises Networks\FeedForward\FeedForward. That can make coverage reporting misleading. Consider switching the CoversClass target to FeedForward::class (or add an explicit covers attribute for it).

#[Group('NeuralNet')]
#[CoversClass(Network::class)]
class NetworkTest extends TestCase

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[apphp]

Fixed

[apphp]

Done

[apphp]

Done

[apphp]

[andrewdalpino]

This is great @apphp, thanks for fixing these issues.

[andrewdalpino]

Nice