Skip to content
This repository was archived by the owner on Mar 1, 2021. It is now read-only.

Replaced www.google.com by finance.google.com#56

Merged
antstorm merged 1 commit intoRubyMoney:masterfrom
buyco:master
Sep 12, 2017
Merged

Replaced www.google.com by finance.google.com#56
antstorm merged 1 commit intoRubyMoney:masterfrom
buyco:master

Conversation

@smennesson
Copy link
Copy Markdown
Contributor

Hi, it seems Google has changed something and that www.google.com/finance/converter is now redirecting to finance.google.com/finance/converter without giving the currency conversion. So the current version does not work any more. The fix is simple, I just had to replace www.google.com by finance.google.com

@AlexWayfer
Copy link
Copy Markdown
Contributor

@smennesson, thank you for PR!

@semmons99, @antstorm, it's very important! Our server in Germany went down due to this unexpected behavior from Google (GoogleCurrencyFetchError). Please, accept this PR and release a new version of gem.

finance.google.com has text in footer:

Google Finance Beta available in: Hong Kong - Canada - U.S. - China - U.K.

And there is no redirect from Russian Federation.

Attempt to show region-based redirect: geopeeker.com (screenshot from Singapore has empty fields for me, which means the redirect was occured).

@jirihradil
Copy link
Copy Markdown

Just a notice, the url https://www.google.com/finance/converter still works for me (currently in Prague, Czechia, Europe).

@antstorm
Copy link
Copy Markdown
Contributor

@smennesson thank you for the PR. It seems like both pages work fine for me, same goes for when trying to load the page via geokeeper.

@antstorm antstorm merged commit fa6e8ba into RubyMoney:master Sep 12, 2017
@antstorm
Copy link
Copy Markdown
Contributor

I will release the updated version later today

@smennesson
Copy link
Copy Markdown
Contributor Author

smennesson commented Sep 12, 2017

@jirihradil https://www.google.com/finance/converter is still responding, but it is not acting like the gem is expecting. It is only redirecting to finance.google.com without displaying the currency conversion.

@AlexWayfer
Copy link
Copy Markdown
Contributor

@jirihradil https://www.google.com/finance/converter is still responding, but it is not acting like the gem is expecting. It is only redirecting to finance.google.com without displaying the currency conversion.

In some regions it's still working without redirects (in Russian Federation, for example, as I said before). But this is not very predictable.

johnboyes pushed a commit to johnboyes/hotcustard-payments that referenced this pull request Jan 6, 2018
johnboyes pushed a commit to johnboyes/hotcustard-payments that referenced this pull request Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants