Conversation
Configure Chrome WebDriver to launch the locally installed Chromium snap.
Open the app URL before clearing storage to avoid SecurityError on about:blank in Firefox.
Update order history URL, password field locators and order number matching for the current UI.
Store refresh token for UI auth, simplify bun drag-and-drop, and harden modal closing.
Ensure logged-in scenarios use both access and refresh tokens from the API fixture.
Replace partial report artifacts with results from the latest test run.
The previous selector targeted orderListReady («Готовы»).
Keep all page elements used in recovery tests described as locators.
Replace list scanning, regex parsing, and callback waits with direct locators and plain refresh loops.
added 24 commits
July 20, 2026 10:57
Use EC waits and direct assertions instead of helper predicates and nested wait callbacks.
Drop unused refresh token and replace next() with a plain loop.
Drop per-call timeout overrides and click through WebElement.click().
Replace the sleep loop with ORDER_NUMBER_READY and open the sauces tab explicitly before adding a sauce.
Share order creation across feed tests and clear cookies only.
Use timeout=5 in wait signatures and return real is_displayed checks.
Use Selenium ActionChains with move_to_element so ingredients outside the viewport are added to the basket without custom HTML5 event script.
Use default timeout=3 for shared waits and WebDriverWait(..., 10) inline for slow order/feed checks, matching the Sprint_6 pattern.
Extract browser creation into a Factory so tests pick the driver by name, as in the cross-browser cheat sheet.
Wire the driver fixture to the factory and reset cookies plus localStorage so Firefox does not keep a stuck auth/loading state.
Wait for the loading overlay before clicks, refresh if it hangs, and dispatch HTML5 drag events via JS so ingredient DnD works in Firefox.
Counters update on the open feed page once the new order shows under «В работе», so reopening the page is unnecessary and flaky.
Refresh Allure artifacts after a full green Chrome and Firefox run.
Without move_to_element, off-screen ingredients (e.g. sauces) never land in the basket, so Chrome counter assertions fail.
Use scope="class" on the parametrized driver fixture so Chrome/Firefox sessions are reused within each test class.
Refresh allure_results after the full suite run with Chrome green.
klushcheva
reviewed
Jul 20, 2026
| feed_page.go_to_constructor() | ||
|
|
||
| assert FEED_URL not in driver.current_url | ||
| assert driver.current_url.startswith(BASE_URL) |
There was a problem hiding this comment.
Нужно поправить: в подходе РОМ мы не обращаемся напрямую в драйвер (как тут driver.current_url): всё оборачиваем в методы пейджа
|
✅ Сильные стороны:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.