fix(deps): refresh the lockfile off three vulnerable transitive versions - #18
Merged
Merged
Conversation
`npm ci` installed minimatch 9.0.5, brace-expansion 2.0.2 and lodash 4.17.21 — three high-severity advisories between them (ReDoS, DoS by memory exhaustion, prototype pollution and code injection via `_.template`). Development and CI were therefore testing against vulnerable dependencies. Consumers were never exposed: our ranges are caret ranges, so a fresh install of the published package resolves the patched versions on its own — verified by installing ruleofcode@7.17.5 from the registry into an empty project, which audits clean. Only this repository's pinned lockfile was stale. package.json is untouched; the ranges already admitted the patched versions. `npm audit --omit=dev` now reports zero vulnerabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm ciinstalled minimatch 9.0.5, brace-expansion 2.0.2 and lodash 4.17.21 — three high-severity advisories between them (ReDoS, DoS by memory exhaustion, prototype pollution, code injection via_.template). Development and CI were testing against vulnerable dependencies.Consumers were never exposed
Verified, not assumed: installing
ruleofcode@7.17.5from the registry into an empty project resolves the patched versions and audits clean.Our ranges are caret ranges, so npm resolves the patched versions on its own. Only this repository's pinned lockfile was stale.
Scope
package.jsonis untouched — the ranges already admitted the patched versions.npm audit --omit=devnow reports 0 vulnerabilities.Gate
npx jest— 504 suites / 13866 tests, exit 0npm run lint— 0 errorsnode dist/cli.js audit— passed 35, failed 0