Bugfix/canary hardcoded package path - #4
Merged
Conversation
Bumps package.json and hooks/installer VERSION to 7.17.3 and regenerates the tracked .husky hooks. schemaVersion stays 2. This is the first version published to npm, as `ruleofcode`. Ships what is already on develop: - fix(laws): Branch Governance failed on every detached-HEAD checkout — the normal state in CI — so every consumer's pipeline went red on a law about branch naming. The branch is now read from the CI environment, and when nothing names one the law reports no violation instead of inventing one. - fix(ci): our own gate never ran (it triggered on a branch that no longer exists) and would have passed vacuously on a shallow clone. Fixing that is what surfaced the bug above. - docs: a pull request template. Gate: eslint 0, 502 suites / 13854 tests (jest exit 0), canary green (py100/ng136/node78). Self-audit: passed 35, failed 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Release/v7.17.3
The tarball probe looked for the installed CLI at a hard-coded `node_modules/@ruleofcode/core/dist/cli.js`. RoC now also ships unscoped as `ruleofcode`, which npm installs at `node_modules/ruleofcode`, so the probe found nothing and reported all three stacks as "the audited CLI did not run" — the release gate calling a perfectly good package broken. The path is now derived from the name in package.json, which handles a scoped name (two path segments) and an unscoped one alike, and a missing binary now fails with the path it looked for instead of a module-loader stack trace. Verified against the real 7.17.3 tarball: green exit 0, red exit 1, zero-laws refused, on python, angular and node. This script is not part of the published package; nothing shipped changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Verdict impact
(then: state the before/after values and what a consumer must do)
Evidence
tests/detectionLimitsupdated if what the detector cannot see has changedGate
npm run lint— 0 errorsnpx jest— full suite greennpm run canary— red/green proven across stacksnode dist/cli.js audit— RuleOfCode still passes its own lawNotes for the reviewer