BNG setup & upgrade commands#6
Merged
Merged
Conversation
wshlavacek
added a commit
to wshlavacek/BNG_vscode_extension
that referenced
this pull request
May 30, 2026
checkUnusedParameters built its reference corpus from rule, function, seed-species, action, and compartment text plus the energy half of energy patterns, but omitted observable patterns and the pattern half of energy patterns. Because parseEnergyPatternLine splits the energy off at the last whitespace, a multi-token energy expression (e.g. "Gbond * 0.5") leaves the parameter in the pattern half, so a genuinely used parameter was falsely flagged "never referenced". Add both pattern sources to the corpus. Addresses PR RuleWorld#29 review finding RuleWorld#6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.