cleaned up code#9
Merged
Merged
Conversation
wshlavacek
added a commit
to wshlavacek/BNG_vscode_extension
that referenced
this pull request
May 30, 2026
onReferences stripped comments with indexOf('#'), which misfires on a '#'
inside a quoted string and could hide a real reference. Reuse the parser's
string-aware stripComment (now exported) to compute the comment boundary.
Also document two existing heuristics: the last-token rate split in
parseRuleLine, and getEnclosingBlockType's reliance on doc.blocks being
ordered by close time so the innermost nested block is matched first.
Addresses PR RuleWorld#29 review finding RuleWorld#9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.