Accept trailing whitespace between \ and newline in line continuations#85
Merged
jrfaeder merged 4 commits intoMay 11, 2026
Conversation
`BNGFile.strip_actions` collapses `\<newline>` continuations before
stripping action lines, but the regex `r"\\\n"` rejects shapes like
method=>"ode",\<space><newline>
which appear in real-world BNGL. BNG2.pl tolerates trailing whitespace
between the `\` and the newline; the modelapi parser should too.
Fix: loosen the regex to `r"\\[ \t]*\n"`.
Resolved conflict by combining: - Comment-aware continuation handling from main (don't collapse backslashes in comments) - Trailing whitespace tolerance from this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`BNGFile.strip_actions` collapses `\` continuations before stripping action lines, but the regex `r"\\n"` rejects shapes like:
```
method=>"ode",<space>
```
which appear in real-world BNGL. BNG2.pl tolerates trailing whitespace between the `\` and the newline; the modelapi parser should too.
Fix
Loosen the regex to `r"\[ \t]*\n"`.
Note on conflict with #79
This PR and #79 ("Don't collapse `\` continuations inside commented BNGL lines") both modify the same line. Logically the two fixes compose — the combined regex would be `r"^([^#\n])\[ \t]\n"` with MULTILINE — but I've kept them as separate PRs per the audit's split guidance. Whichever lands first, the other can rebase trivially.
Test plan