Skip to content

CI-001B4B: Retire one stale AdminMembers lint directive#241

Merged
daliu merged 1 commit into
mainfrom
codex/issue-239-adminmembers-lint
Jul 14, 2026
Merged

CI-001B4B: Retire one stale AdminMembers lint directive#241
daliu merged 1 commit into
mainfrom
codex/issue-239-adminmembers-lint

Conversation

@daliu

@daliu daliu commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Closes #239

Outcome

Removes exactly one stale react-hooks/exhaustive-deps suppression comment from AdminMembers.tsx. Because that rule is not defined in the current lint configuration, the comment itself was one configured lint error.

The exact reviewed ledger now contains 106 files, 123 errors, and 7 warnings. TSX errors are 93 and the fingerprint is sha256:199771a215cc460da8b2d37433a69027d0d459658b07869ed61dbff0bc44525d.

Preserved boundaries

  • Every executable statement, effect dependency, Firebase call, and runtime behavior is unchanged.
  • The lint rule set, configuration, checker, workflow, packages, and locks are unchanged.
  • Exactly one normalized finding is removed and zero are added.
  • This is a focused debt reduction, not a clean-lint claim.
  • All PAY-002B2C4B — Persist attempt-2 Checkout Session pre-send evidence #238 C4B/PAY/Checkout Session paths and semantic hunks remain unchanged.

Build artifacts may change mechanically because a source comment was removed; byte-identical build output is not claimed.

Verification

  • Pre-change proof identified exactly the one AdminMembers unknown-rule directive record.
  • With only the source comment removed, the old ledger failed closed with frontend_lint_gate_failed:lint_rejected.
  • Regenerated baseline matches the committed JSON byte-for-byte.
  • Direct Node 20 lint: 106 files / 123 errors / 7 warnings.
  • Workflow and artifact safety: 29/29 passed.
  • Frontend: 240/240 passed.
  • SPA navigation: 11/11 passed.
  • Functions lint: passed.
  • Functions: 1,512 passed; 53 conditional/emulator skips.
  • Firestore Rules: 372/372 passed under Java 17 and demo project demo-rules-test.
  • Commerce journal emulator: 52/52 passed under demo project demo-pay002b2-test.
  • Optimized diagnostic build: passed.
  • git diff --check: passed.
  • Two independent exact-diff reviews: passed with no actionable findings.
  • Exactly the seven issue-owned paths changed.

Coordination

Active #238 edits the same physical long RISK-035 row only for its separately owned commerce-suite suffix. The later merger must preserve both this PRs 106/123/7 lint wording and #238s final commerce list through #238. No C4B/PAY text is changed here.

Officer impact: None. This removes one internal suppression comment and updates the exact lint-debt ledger. No public wording, member flow, admin task, permission, collected data, or provider behavior changes.

Officer documentation: None — no officer procedure or public/admin behavior changes.

Deployment evidence: Source and local tests only. No website publication, Firebase deployment, Stripe/Strava/provider action, production-data action, migration, or live behavior verification was performed.

@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit 9219e4e
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a55da38a576ed000854060a
😎 Deploy Preview https://deploy-preview-241--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu daliu merged commit 4dc69d4 into main Jul 14, 2026
9 checks passed
@daliu daliu deleted the codex/issue-239-adminmembers-lint branch July 14, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI-001B4B — Retire one stale AdminMembers lint directive

1 participant