Skip to content

Make books use PTX generate templates for student pages by default - #1336

Merged
bnmnetp merged 2 commits into
RunestoneInteractive:mainfrom
ascholerChemeketa:default-ptx-pages-true
Aug 2, 2026
Merged

Make books use PTX generate templates for student pages by default#1336
bnmnetp merged 2 commits into
RunestoneInteractive:mainfrom
ascholerChemeketa:default-ptx-pages-true

Conversation

@ascholerChemeketa

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings August 1, 2026 17:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the default behavior for the use_pretext_student_pages course attribute so that student pages use the PreTeXt-generated templates by default, and centralizes the “string is true” coercion logic in a shared CRUD helper.

Changes:

  • Added course_attr_is_true() helper to interpret course attribute values as booleans.
  • Updated book, assignment-student, and admin-instructor routers to use the helper and default use_pretext_student_pages to True.
  • Exported the new helper via rsptx.db.crud for reuse.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
components/rsptx/db/crud/course_attrs.py Adds a shared boolean-coercion helper for course attributes.
components/rsptx/db/crud/init.py Re-exports the new helper from the CRUD package.
bases/rsptx/book_server_api/routers/course.py Switches use_pretext_student_pages detection to the helper and defaults it on.
bases/rsptx/assignment_server_api/routers/student.py Switches use_pretext_student_pages detection to the helper and defaults it on (two call sites).
bases/rsptx/admin_server_api/routers/instructor.py Makes the admin course settings view default the toggle on via the helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings August 1, 2026 17:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@bnmnetp
bnmnetp merged commit 2b93515 into RunestoneInteractive:main Aug 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants