fix(dashboard): add missing vite alias for compound-engineering plugin#1464
Conversation
|
Too much diff to scan? Review this PR in Change Stack to start with the highest-impact changes. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds two Vite resolve.alias entries for the ChangesModule Alias Configuration and Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdds the missing
Confidence Score: 5/5Safe to merge — the change is a targeted config addition with no logic modifications. Both target files (src/dashboard-view.tsx and src/index.ts) exist at the referenced paths, the alias ordering is correct (sub-path before package root, matching Vite's first-match semantics), and the pattern is identical to the already-working dependency-graph aliases. The documentation accurately reflects the fix and the real module resolution behavior. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Dashboard as Dashboard App
participant Vite as Vite Dev Server
participant Alias as resolve.alias map
participant Plugin as fusion-plugin-compound-engineering/src
Dashboard->>Vite: "import(moduleId) where moduleId = "@fusion-plugin-examples/compound-engineering/dashboard-view""
Vite->>Alias: "look up "@fusion-plugin-examples/compound-engineering/dashboard-view""
Note over Alias: Before PR: no match → resolution fails<br/>After PR: matches → plugins/.../src/dashboard-view.tsx
Alias-->>Vite: resolved path (dashboard-view.tsx)
Vite-->>Plugin: load and transform
Plugin-->>Dashboard: CompoundEngineeringDashboardView component
Reviews (2): Last reviewed commit: "docs(solutions): document bundled plugin..." | Re-trigger Greptile |
Adds the missing Vite
resolve.aliasentries for@fusion-plugin-examples/compound-engineeringso the dashboard can load the plugin's view and index modules. Without these aliases, the dynamic import inregisterBundledPluginViews.tsfails to resolve, causing the Compound Engineering plugin to fail to enable.Summary by CodeRabbit
Chores
Documentation