fix: resolve claude-runtime probe source for CLI full-suite#2292
Conversation
Full-suite shard 4 failed CLI suites importing dashboard runtime-provider- probes when Vite resolved @fusion-plugin-examples/claude-runtime to dist/ and the full ACP graph. Alias CLI tests to a thin probes-entry source module.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds a thin Claude runtime probe entrypoint and updates CLI Vitest aliases to resolve the probe and package imports to source modules, avoiding full plugin-index resolution. ChangesClaude runtime probe resolution
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes Claude runtime probe resolution in the CLI test suite. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix: export ClaudeBinaryStatus from prob..." | Re-trigger Greptile |
## Summary Full Suite after #2292: shards 1–3 green; shard 4 failed FN-7537 backup automation tests with `store.getGlobalSettingsDir is not a function`. - Add `getGlobalSettingsDir` to routes-automation mock store - Point backup-parity fixtures’ global dir at the temp fusion dir - Dashboard Vitest: alias `@fusion-plugin-examples/claude-runtime` → `probes-entry` (same class as CLI #2292) ## Test plan - [x] Local manual backup run parity (4 tests) - [ ] PR gate - [ ] Post-merge Full Suite <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved automation backup test coverage for global backup directory handling. * Preserved reliable manual backup behavior and event ordering across supported automation steps. * Fixed dashboard API test configuration for Claude runtime probe resolution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Full Suite after #2291: shards 1–3 green; shard 4 failed CLI suites with:
Failed to resolve entry for package "@fusion-plugin-examples/claude-runtime"from
dashboard/src/runtime-provider-probes.tsunder the CLI vitest package lane.plugins/fusion-plugin-claude-runtime/src/probes-entry.ts(probe + model discovery only)@fusion-plugin-examples/claude-runtimeto that entry in CLI vitest config (same class as Cursor/Grok/OMP source aliases, but avoids ACP index load)Test plan
Summary by CodeRabbit