test(engine): assert mutation-context attribution across engine suites (4/5) - #3432
Open
gsxdsm wants to merge 7 commits into
Open
test(engine): assert mutation-context attribution across engine suites (4/5)#3432gsxdsm wants to merge 7 commits into
gsxdsm wants to merge 7 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
| Filename | Overview |
|---|---|
| packages/engine/src/tests/mutation-context-matchers.ts | Adds distinct attributed and unattributed context matchers; the attributed matcher now rejects the exact marker identified by the prior review. |
| packages/engine/src/tests/mutation-context-matchers.test.ts | Adds direct controls proving attributed contexts pass while unattributed, missing, and empty contexts fail. |
| packages/engine/src/executor/worktree-branch-conflict-handle.ts | Attributes the reclaimed-worktree task update using the same executor run context used by the recovery log. |
Reviews (14): Last reviewed commit: "Merge remote-tracking branch 'origin/ide..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
gsxdsm
force-pushed
the
identity/3-engine-src
branch
from
August 14, 2026 03:46
e26a7ef to
d407a8d
Compare
gsxdsm
force-pushed
the
identity/4-engine-tests
branch
from
August 14, 2026 03:46
404e3a8 to
be439e7
Compare
gsxdsm
force-pushed
the
identity/3-engine-src
branch
from
August 14, 2026 03:54
d407a8d to
5ce4b60
Compare
gsxdsm
force-pushed
the
identity/4-engine-tests
branch
from
August 14, 2026 03:54
be439e7 to
a167214
Compare
gsxdsm
force-pushed
the
identity/3-engine-src
branch
from
August 14, 2026 04:01
5ce4b60 to
8c23e8c
Compare
gsxdsm
force-pushed
the
identity/4-engine-tests
branch
from
August 14, 2026 04:01
a167214 to
3129138
Compare
Collaborator
Author
|
@coderabbitai review |
Contributor
|
Collaborator
Author
|
Review feedback addressed in Fixed — the findings were correct:
The matcher finding deserves its own note. It was exactly right, and the blast radius was real: tightening exposed 15 genuinely unattributed writes across 11 suites that the loose matcher had been passing as attributed. Those now assert Not applied, with reasons:
Verification. Measured against a baseline of the same tree with these edits reverted, so pre-existing failures aren't attributed to this change: 77 failed files / 258 failed tests before → 77 / 263 after, with no file this change touches newly failing. |
This was referenced Aug 14, 2026
gsxdsm
force-pushed
the
identity/3-engine-src
branch
from
August 14, 2026 20:02
8c23e8c to
ff02870
Compare
gsxdsm
force-pushed
the
identity/4-engine-tests
branch
from
August 14, 2026 20:02
3129138 to
ccec4fb
Compare
gsxdsm
force-pushed
the
identity/3-engine-src
branch
from
August 14, 2026 20:10
ff02870 to
2127d7d
Compare
gsxdsm
force-pushed
the
identity/4-engine-tests
branch
from
August 14, 2026 20:10
ccec4fb to
626dc8b
Compare
Collaborator
Author
|
Stack rebased so every chunk carries its own review fixes; the stack tip is byte-identical to the full branch ( One further real finding fixed ( Re-posted findings that are already fixed in the current tree (the bot re-reviewed against pre-fix line numbers):
Still declined: the FNXC-trace requests across the executor files. All ten already carry FNXC comments and the changed blocks are mechanical propagation of a conversion documented once at its seam; ten near-identical "attribution threaded here" notes are noise, not traceability. CI: #3428 7/7 green, #3429 6/6, #3431–#3433 all green. The only red mark is the Greptile check itself, which reports its own open findings rather than a build result. |
gsxdsm
force-pushed
the
identity/3-engine-src
branch
from
August 15, 2026 05:46
2127d7d to
1e03e16
Compare
gsxdsm
force-pushed
the
identity/4-engine-tests
branch
from
August 15, 2026 05:46
626dc8b to
6b1eba8
Compare
gsxdsm
force-pushed
the
identity/3-engine-src
branch
from
August 15, 2026 22:55
1e03e16 to
14d1a33
Compare
gsxdsm
force-pushed
the
identity/4-engine-tests
branch
from
August 15, 2026 22:55
6b1eba8 to
2ed6e5f
Compare
gsxdsm
force-pushed
the
identity/3-engine-src
branch
from
August 17, 2026 23:37
14d1a33 to
621502b
Compare
gsxdsm
force-pushed
the
identity/4-engine-tests
branch
from
August 17, 2026 23:37
2ed6e5f to
ac4c482
Compare
gsxdsm
force-pushed
the
identity/3-engine-src
branch
from
August 23, 2026 23:12
621502b to
55db108
Compare
…all site (4/5) Includes the tightened ANY_MUTATION_CONTEXT matcher (it previously accepted the "system:unattributed" marker, so every assertion using it passed whether the write was attributed or not) plus its own proven-failing controls. Fusion-Task-Id: FN-8821 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
gsxdsm
force-pushed
the
identity/4-engine-tests
branch
from
August 23, 2026 23:14
ac4c482 to
ab5d8ca
Compare
Restack 4/5 onto the updated 3/5 base. Conflict resolutions keep both sides: - executor-worktree.test.ts: 3/5 reclaim provenance (branch + branchWriteOrigin, including the operator-owned Fusion-namespaced case) plus 4/5 ANY_MUTATION_CONTEXT. - identity-permissions-shadow.test.ts (add/add): union 4/5 shadow-evaluation suites with the 3/5 gitCases it.each corpus and null-git assertion.
…tity/4-engine-tests
The restacked 3/5 reclaim patch stamps branchWriteOrigin; pass runContextFor on that updateTask so 4/5 ANY_MUTATION_CONTEXT assertions stay true. Fusion-Task-Id: FN-8821
…tity/4-engine-tests
# Conflicts: # packages/engine/src/__tests__/executor-step-session.test.ts
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| log: [], | ||
| branch: "fusion/fn-permission-denied", | ||
| baseBranch: "main", | ||
| worktree: "/tmp/fusion-fn-permission-denied", |
| maxWorktrees: 4, | ||
| pollIntervalMs: 15000, | ||
| }); | ||
| const executor = new TaskExecutor(store, "/tmp/test"); |
|
|
||
| function makeExecutor() { | ||
| const store = createMockStore(); | ||
| const executor = new TaskExecutor(store, "/tmp/test") as unknown as { |
| "FN-050", | ||
| expect.stringContaining("Cleaned up conflicting worktree, retrying"), | ||
| "/tmp/test/.worktrees/swift-falcon", | ||
| "/tmp/test/.worktrees/swift-falcon", ANY_MUTATION_CONTEXT, |
| expect(execMock).not.toHaveBeenCalledWith(expect.stringContaining("git worktree remove --force"), expect.anything()); | ||
| expect(execMock).not.toHaveBeenCalledWith(expect.stringContaining("git branch -D"), expect.anything()); | ||
| expect(store.updateTask).toHaveBeenCalledWith("FN-9001", expect.objectContaining({ worktree: "/tmp/live", branch: "fusion/fn-9001" })); | ||
| expect(store.updateTask).toHaveBeenCalledWith("FN-9001", expect.objectContaining({ worktree: "/tmp/live", branch: "fusion/fn-9001" }), UNATTRIBUTED_MUTATION_CONTEXT); |
| expect(recovered).toBe(1); | ||
| expect(execMock).not.toHaveBeenCalledWith(expect.stringContaining("git worktree remove --force"), expect.anything()); | ||
| expect(store.updateTask).toHaveBeenCalledWith("FN-9001", expect.objectContaining({ worktree: "/tmp/live", branch: "fusion/fn-9001" })); | ||
| expect(store.updateTask).toHaveBeenCalledWith("FN-9001", expect.objectContaining({ worktree: "/tmp/live", branch: "fusion/fn-9001" }), UNATTRIBUTED_MUTATION_CONTEXT); |
|
|
||
| expect(execMock).not.toHaveBeenCalledWith(expect.stringContaining("git worktree remove --force"), expect.anything()); | ||
| expect(store.updateTask).toHaveBeenCalledWith("FN-9001", expect.objectContaining({ worktree: "/tmp/live", branch: "fusion/fn-other" })); | ||
| expect(store.updateTask).toHaveBeenCalledWith("FN-9001", expect.objectContaining({ worktree: "/tmp/live", branch: "fusion/fn-other" }), UNATTRIBUTED_MUTATION_CONTEXT); |
Contributor
ThreatCrush Security Scan4524 finding(s) HIGH/CRITICAL: 43 | MEDIUM: 3990 | LOW: 491
…and 4474 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
# Conflicts: # packages/engine/src/__tests__/auto-recovery-branch-worktree.test.ts # packages/engine/src/__tests__/executor-execution-policy-renamed-columns.test.ts # packages/engine/src/__tests__/executor-graph-requeue-gate.test.ts # packages/engine/src/__tests__/executor-outer-dispatch-dependency-gate.test.ts # packages/engine/src/__tests__/executor-step-session.test.ts # packages/engine/src/__tests__/executor-worktree.test.ts # packages/engine/src/__tests__/merger-ai.test.ts # packages/engine/src/__tests__/merger-finalize-unproven.real-git.test.ts # packages/engine/src/__tests__/merger-merge-lifecycle.test.ts # packages/engine/src/__tests__/merger-trait-rekey.test.ts # packages/engine/src/__tests__/promote-force-unplanned.test.ts # packages/engine/src/__tests__/reliability-interactions/auto-revive-and-watchdog.test.ts # packages/engine/src/__tests__/reliability-interactions/merge-node-paused-abort-retryable.test.ts # packages/engine/src/__tests__/reliability-interactions/todo-inprogress-flapping.test.ts # packages/engine/src/__tests__/reliability-interactions/worktree-incomplete-session-start.test.ts # packages/engine/src/__tests__/replan-target.test.ts # packages/engine/src/__tests__/restart-recovery-coordinator.test.ts # packages/engine/src/__tests__/self-healing-ghost-branch-recovery.test.ts # packages/engine/src/__tests__/self-healing-in-progress-limbo.test.ts # packages/engine/src/__tests__/self-healing-query-filter-blindness.test.ts # packages/engine/src/__tests__/self-healing-reclaim-live-zero-commits.test.ts # packages/engine/src/__tests__/self-healing-reclaim-paused-review.test.ts # packages/engine/src/__tests__/self-healing-trait-rekey.test.ts # packages/engine/src/__tests__/self-healing.test.ts # packages/engine/src/__tests__/workflow-graph-optional-step-fix.test.ts
| import * as worktreePoolModule from "../../worktree/worktree-pool.js"; | ||
|
|
||
| function git(cwd: string, command: string): string { | ||
| return execSync(`git ${command}`, { cwd, encoding: "utf8", stdio: ["pipe", "pipe", "pipe"] }).trim(); |
| logEntry: vi.fn().mockResolvedValue(undefined), | ||
| moveTask: vi.fn().mockResolvedValue(undefined), | ||
| recordRunAuditEvent: vi.fn().mockResolvedValue(undefined), | ||
| getRootDir: vi.fn().mockReturnValue("/tmp/test-project"), |
| column: "in-progress", | ||
| paused: false, | ||
| branch: null, | ||
| worktree: "/tmp/test-project/.worktrees/missing-fn-5149", |
| (store.listTasks as ReturnType<typeof vi.fn>).mockResolvedValue([baseTask]); | ||
|
|
||
| const manager = new SelfHealingManager(store, { | ||
| rootDir: "/tmp/test-project", |
| vi.mocked(existsSync).mockImplementation((path) => path === baseTask.worktree); | ||
| (store.listTasks as ReturnType<typeof vi.fn>).mockResolvedValue([baseTask]); | ||
| const manager = new SelfHealingManager(store, { | ||
| rootDir: "/tmp/test-project", |
| it("skips tasks whose branch is still set", async () => { | ||
| (store.listTasks as ReturnType<typeof vi.fn>).mockResolvedValue([{ ...baseTask, branch: "fusion/fn-5149" }]); | ||
| const manager = new SelfHealingManager(store, { | ||
| rootDir: "/tmp/test-project", |
| it("skips tasks currently claimed by the executor", async () => { | ||
| (store.listTasks as ReturnType<typeof vi.fn>).mockResolvedValue([baseTask]); | ||
| const manager = new SelfHealingManager(store, { | ||
| rootDir: "/tmp/test-project", |
| it("skips paused tasks", async () => { | ||
| (store.listTasks as ReturnType<typeof vi.fn>).mockResolvedValue([{ ...baseTask, paused: true }]); | ||
| const manager = new SelfHealingManager(store, { | ||
| rootDir: "/tmp/test-project", |
| it("skips tasks still within the grace window", async () => { | ||
| (store.listTasks as ReturnType<typeof vi.fn>).mockResolvedValue([{ ...baseTask, updatedAt: "2026-05-20T12:04:30.000Z" }]); | ||
| const manager = new SelfHealingManager(store, { | ||
| rootDir: "/tmp/test-project", |
| }); | ||
| (store.listTasks as ReturnType<typeof vi.fn>).mockResolvedValue([baseTask]); | ||
| const manager = new SelfHealingManager(store, { | ||
| rootDir: "/tmp/test-project", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 4/5 — 126 files. Base:
identity/3-engine-src.Test-only. Asserts the mutation context positionally rather than waving it through, so the day U9/U11/U13 hand a path a real actor, the assertion fails and names the line instead of silently accepting whatever arrived.
🤖 Generated with Claude Code