[Fix] #154 - 1차 릴리즈 QA 2차 반영 #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsj8706
approved these changes
May 30, 2023
Collaborator
lsj8706
left a comment
lsj8706
left a comment
There was a problem hiding this comment.
많은 작업을 해주셨네요!!! 👍
수고하셨습니다~!
|
|
||
| let activityTextView = UITextView().then { | ||
| $0.font = .b4 | ||
| private lazy var activityTextView = UITextView().then { |
| let newString = text[text.startIndex..<index] | ||
| self.courseTitleTextField.text = String(newString) | ||
|
|
||
| private func isTextChanged(_ textFieldtext: String, _ textViewtext: String) { |
Collaborator
There was a problem hiding this comment.
Bool값을 리턴하는 경우에 is를 함수나 변수명 앞에 붙이는 경우가 많은 것 같아요!
지금 이 함수는 그런 용도는 아니고 텍스트가 변경되었을 때 처리할 로직을 넣고 있기 때문에
textDidChange 정도로 지정하는 게 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
📮 관련 이슈