Add SET_S4_OBJECT compatibility shim for newer R versions - #2
Merged
Conversation
R removed the SET_S4_OBJECT macro/function from the public API outside of USE_RINTERNALS builds, causing "use of undeclared identifier 'SET_S4_OBJECT'" on R 4.6 with Apple clang. Define it in terms of the still-public Rf_asS4, which sets the S4 bit on an object. https://claude.ai/code/session_01ScgcJJ2KtznxpVtKtKE2NH
There was a problem hiding this comment.
Pull request overview
Adds an R-version compatibility shim to keep the package building against newer R releases where SET_S4_OBJECT is no longer available in the public headers (outside USE_RINTERNALS).
Changes:
- Define
SET_S4_OBJECTwhen missing, implemented viaRf_asS4(..., TRUE, 0)to set the S4 bit using the stable API.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R removed the SET_S4_OBJECT macro/function from the public API outside of USE_RINTERNALS builds, causing "use of undeclared identifier 'SET_S4_OBJECT'" on R 4.6 with Apple clang. Define it in terms of the still-public Rf_asS4, which sets the S4 bit on an object.
https://claude.ai/code/session_01ScgcJJ2KtznxpVtKtKE2NH