Make Rust CI workflows zizmor compliant#38
Open
fedonman wants to merge 1 commit into
Open
Conversation
Pin every action reference in the Rust CI additions to a full commit SHA, as required by the repository's zizmor blanket policy: * dtolnay/rust-toolchain -> ab40b01 (1.91.1) and 4cda84d (stable) * actions/checkout -> 9c091bb (v7.0.0), matching the rest of the repo dtolnay/rust-toolchain derives the installed toolchain from the action ref, so hash-pinning it requires an explicit `toolchain:` input; add one wherever it was not already present. Also switch the x64 "Install LLVM for bindgen" step from `shell: cmd` to `shell: pwsh`, mirroring the existing ARM64 step, to resolve the remaining zizmor misfeature finding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust CI additions introduced action references that the repository's zizmor blanket policy flags: 6
unpinned-useserrors and 1misfeaturefinding (see the failing run).This pins every action in the Rust CI files to a full commit SHA (with a version comment), matching how the rest of the repo pins its actions:
dtolnay/rust-toolchain@1.91.1→ab40b01f54fe82bdf65693ea090a1e4942c136e7 # 1.91.1(insetup-rust-windows/action.yml,build.yml×2,reusable-wasi.yml)dtolnay/rust-toolchain@stable→4cda84d5c5c54efe2404f9d843567869ab1699d4 # stable(cargo.yml)actions/checkout@v6→9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0(cargo.yml), the same pin used everywhere else in the repodtolnay/rust-toolchainderives the toolchain from the action ref, so hash-pinning it breaks that inference. I've added an explicittoolchain:input wherever it was pinned to a hash and one wasn't already present.For the remaining
misfeaturefinding, the x64 Install LLVM for bindgen step is switched fromshell: cmdtoshell: pwsh, mirroring the existing ARM64 step in the same file (sameTest-Pathguard andGITHUB_ENVwrite).Fixes #37