fix: emscripten build failed after new wasm-bindgen is published - #1111
Merged
Conversation
Decodetalkers
force-pushed
the
fix_emscripten
branch
from
February 22, 2026 14:45
712f1fa to
fb756bc
Compare
roderickvd
reviewed
Feb 23, 2026
roderickvd
left a comment
roderickvd
left a comment
Member
There was a problem hiding this comment.
👍 Minor nit: we could import std::panic::AssertUnwindSafe at the top, so we don't have to repeat its full path in three places.
Member
|
I see I've got write access on your repo - thanks - I'll update and merge it. |
roderickvd
force-pushed
the
fix_emscripten
branch
from
February 23, 2026 20:25
c3bfd10 to
452cd31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.