Skip to content

fix(asio): enumerate devices without known sample rate #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roderickvd merged 1 commit into from
Feb 25, 2026
Merged

fix(asio): enumerate devices without known sample rate #1112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions src/host/asio/device.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,12 +183,9 @@ impl Iterator for Devices {
continue;
}

let Ok(sample_rate) = driver.sample_rate() else {
continue;
};
if sample_rate == 0.0 {
continue;
}
// Some drivers (e.g. Realtek ASIO) return 0 for sample_rate() until a
// stream is active. Treat 0 as "not yet known" rather than skipping.
let sample_rate = driver.sample_rate().unwrap_or(0.0);

let Ok((buffer_size_min, buffer_size_max)) = driver.buffersize_range()
else {
Expand All @@ -203,18 +200,12 @@ impl Iterator for Devices {
.output_data_type()
.ok()
.and_then(|t| convert_data_type(&t));
if input_sample_format.is_none() && output_sample_format.is_none() {
continue;
}

let supported_sample_rates: Vec<SampleRate> = crate::COMMON_SAMPLE_RATES
.iter()
.copied()
.filter(|&r| driver.can_sample_rate(r.into()).unwrap_or(false))
.collect();
if supported_sample_rates.is_empty() {
continue;
}

self.current_driver = Some(driver);

Expand Down