Add sample-based generation example: synth_tones #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please let me know if any adjustments are required. |
est31
requested changes
Nov 16, 2021
Contributor
Author
|
@est31 sure! done. anything else? |
Contributor
Author
|
;) |
Member
|
Sorry for the long delay, I think I've enabled CI on it and then lost track of the PR. It's a bit annoying that it doesn't ping you after CI is finished. |
Contributor
Author
|
Thanks for good open source) |
Contributor
|
If you set CI as required in branch prediction, you can enable automerge on CI green, which is pretty handy in these cases. |
zmerp
pushed a commit
to zmerp/cpal
that referenced
this pull request
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample-based generation of sound.
It is refactored version of the example
beep. I bubbled up a callback to generate a sample. Also, I replacedunwrapwith proper handling of errors. That does not add complexity becauseanyhowand?are already in use. That's the first step I would like it was done for me to start playing withcpaland integrating it into my projects.Hopefully, it will be useful for not only me.
#613