Additional methods, tests for MontyForm#1230
Merged
tarcieri merged 3 commits intoRustCrypto:masterfrom Mar 24, 2026
Merged
Conversation
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
+ Coverage 87.99% 89.00% +1.01%
==========================================
Files 184 184
Lines 21244 21347 +103
==========================================
+ Hits 18693 19000 +307
+ Misses 2551 2347 -204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hm, it seems like I might have found a bug in the WASM backend. |
Member
|
@andrewwhitehead WASM-only problems are likely to be a result of |
tarcieri
reviewed
Mar 24, 2026
tarcieri
reviewed
Mar 24, 2026
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
feat/monty-form-methods
branch
from
147d562 to
e66f519
Compare
tarcieri
reviewed
Mar 24, 2026
tarcieri
reviewed
Mar 24, 2026
tarcieri
approved these changes
Mar 24, 2026
Merged
tarcieri
added a commit
that referenced
this pull request
Mar 25, 2026
## Added - `#[inline]` attributes for shift and wrapping arithmetic ops (#1229) - `MontyForm::{is_zero, is_one}` methods (#1230) - `Gcd` supertrait bound to `Unsigned`/`Signed` traits (#1231) ## Changed - Define `Uint` division traits generically (#1232) - Use generic implementation of bit operations for `Wrapping` (#1235) - Explicitly seal `MontyForm` (#1237)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
is_zeroandis_oneconvenience methods forMontyForm, as well asfrom_montgomeryfor returning the result ofinto_montgomeryto this representation.Tests are added to cover the new and existing methods for
FixedMontyFormandBoxedMontyForm.