Define Uint division traits generically#1232
Merged
tarcieri merged 4 commits intoRustCrypto:masterfrom Mar 24, 2026
Merged
Conversation
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
+ Coverage 88.07% 88.67% +0.60%
==========================================
Files 185 185
Lines 21298 21298
==========================================
+ Hits 18759 18887 +128
+ Misses 2539 2411 -128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
feat/generic-uint-div
branch
from
15f2b45 to
993604f
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
tarcieri
approved these changes
Mar 24, 2026
Member
|
Looks like that got us to 90% test coverage, rounding up, according to the badge anyway |
Merged
tarcieri
added a commit
that referenced
this pull request
Mar 25, 2026
## Added - `#[inline]` attributes for shift and wrapping arithmetic ops (#1229) - `MontyForm::{is_zero, is_one}` methods (#1230) - `Gcd` supertrait bound to `Unsigned`/`Signed` traits (#1231) ## Changed - Define `Uint` division traits generically (#1232) - Use generic implementation of bit operations for `Wrapping` (#1235) - Explicitly seal `MontyForm` (#1237)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should support all the old div/rem trait implementations but with better test coverage, as well as
Uint/BoxedUintandUint/UintRefoperations.