Skip to content

ripemd: Add OID support#415

Merged
newpavlov merged 3 commits intoRustCrypto:masterfrom
lumag:ripemd-oid
Sep 23, 2022
Merged

ripemd: Add OID support#415
newpavlov merged 3 commits intoRustCrypto:masterfrom
lumag:ripemd-oid

Conversation

@lumag
Copy link
Copy Markdown
Contributor

@lumag lumag commented Sep 22, 2022

Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

@newpavlov
Copy link
Copy Markdown
Member

newpavlov commented Sep 22, 2022

We need to have an explicit decision on the issue described in #408 before implementing OID support for RIPEMD hashes.

@lumag lumag mentioned this pull request Sep 22, 2022
@lumag
Copy link
Copy Markdown
Contributor Author

lumag commented Sep 22, 2022

@newpavlov let's have this PR open and move the discussion to the mentioned issue. Marking this PR as a draft to prevent merging.

@lumag lumag marked this pull request as draft September 22, 2022 08:19
@newpavlov
Copy link
Copy Markdown
Member

Regardless of our choice, I think it's worth to add a note about existence of multiple OIDs with reference to the issue.

@lumag
Copy link
Copy Markdown
Contributor Author

lumag commented Sep 22, 2022

@newpavlov done

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
@lumag lumag marked this pull request as ready for review September 23, 2022 00:26
@newpavlov newpavlov merged commit 4561d6f into RustCrypto:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants