Remove implementation of BlockSizeUser for XOFs#856
Merged
Conversation
newpavlov
changed the title
BlockSizeUser impls for XOFsBlockSizeUser for XOFs
Merged
newpavlov
added a commit
that referenced
this pull request
May 12, 2026
### Added - `CShake128Reader` and `CShake256Reader` type aliases ([#855]) ### Changed - Internal implementation by removing unnecessary buffering ([#849]) - `Rate: BlockSizes` generic parameter to `const RATE: usize` ([#849]) ### Removed - Implementations of `BlockSizeUser` ([#856]) [#849]: #849 [#855]: #855 [#856]: #856
Merged
newpavlov
added a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary use of
BlockSizeUseris implementation of HMAC. Our implementation inhmacrequires fixed output, so XOFs can not be used with it (withoutXofFixedWrapper). XOFs should not be used with HMAC either way, so we probably can drop the impls.