ascon: 2021 edition - #40
Merged
Merged
Conversation
Since #39 bumped MSRV to 1.59, we can go ahead and do a 2021 edition upgrade, including README.md in the toplevel rustdoc.
tarcieri
added a commit
that referenced
this pull request
Feb 26, 2023
The build is failing because `keccak` has a very old MSRV of 1.41, which after merging #40 (which bumped the `ascon` edition to 2021) broke the build because it can't handle the `edition` key. As a workaround, this excludes `keccak` from the toplevel workspace so it doesn't try to read the `ascon` edition key. Separately, we should probably bump the `keccak` edition to 2021 as well and release `keccak` v0.2.0, but that is left for future work.
tarcieri
added a commit
that referenced
this pull request
Feb 26, 2023
The build is failing because `keccak` has a very old MSRV of 1.41, which after merging #40 (which bumped the `ascon` edition to 2021) broke the build because it can't handle the `edition` key. As a workaround, this excludes `keccak` from the toplevel workspace so it doesn't try to read the `ascon` edition key. Separately, we should probably bump the `keccak` edition to 2021 as well and release `keccak` v0.2.0, but that is left for future work.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #39 bumped MSRV to 1.59, we can go ahead and do a 2021 edition upgrade, including README.md in the toplevel rustdoc.