Skip to content

Replace ascon with ascon-core - #49

Merged
tarcieri merged 6 commits into
RustCrypto:masterfrom
sebastinas:replace-ascon-with-ascon-core
Mar 12, 2023
Merged

Replace ascon with ascon-core#49
tarcieri merged 6 commits into
RustCrypto:masterfrom
sebastinas:replace-ascon-with-ascon-core

Conversation

@sebastinas

Copy link
Copy Markdown
Contributor

The first step of implementing sebastinas/ascon-aead#5

I kept README.md and relicensed the code as Apache-2.0 or MIT.

@sebastinas
sebastinas force-pushed the replace-ascon-with-ascon-core branch from cdabb1a to 878cf49 Compare March 11, 2023 20:26
Comment thread ascon/src/lib.rs Outdated
@tarcieri

tarcieri commented Mar 11, 2023

Copy link
Copy Markdown
Member

The minimal-versions check seems to be failing because criterion misspecifies its minimal supported serde version.

I guess comment out the minimal-versions check for now.

@sebastinas

Copy link
Copy Markdown
Contributor Author

I opted to apply the same workaround as in RustCrypto/formats#720.

@tarcieri
tarcieri requested a review from newpavlov March 11, 2023 21:28
@tarcieri

Copy link
Copy Markdown
Member

@sebastinas after I merged #46 it caused a Cargo.lock conflict. Can you rebase?

Also bump the version to 0.3.0-pre.
This function is only used by `ascon-aead`.
The required version of `regex`and `serde` specified by `criterion` (or
its dependencies) are incorrectly specified.
@sebastinas
sebastinas force-pushed the replace-ascon-with-ascon-core branch from 051af48 to ece4b26 Compare March 11, 2023 21:42
@sebastinas

Copy link
Copy Markdown
Contributor Author

Done

Comment thread ascon/Cargo.toml Outdated
Comment thread ascon/Cargo.toml
@tarcieri
tarcieri merged commit 3e38152 into RustCrypto:master Mar 12, 2023
@tarcieri

Copy link
Copy Markdown
Member

@sebastinas I added you to the "sponges" team which should give you access to this repo as well as access to publish the ascon crate

@sebastinas sebastinas mentioned this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants