[Fix][Carthage] Remove Submodules file #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashfurrow
approved these changes
Nov 27, 2017
Member
ashfurrow
left a comment
ashfurrow
left a comment
There was a problem hiding this comment.
Cool, good catch. Thanks for the contribution and and my apologies for the problem.
Member
|
Thanks a lot for contributing! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since the commit b49959c, this is not working for carthage anymore.
I got the error: "Parse error: expected submodule commit SHA in output of task (ls-tree -z 9c413d3 Carthage/Checkouts/RxSwift) but encountered: "
After some research, apparently, it's because the submodules have been removed.
Carthage/Carthage#135
So, removing the .gitmodules file should do the job.