Skip to content

Updated Swift to 5.0 from 3.0.#64

Merged
fassko merged 2 commits intoRxSwiftCommunity:masterfrom
h1d3mun3:master
May 2, 2019
Merged

Updated Swift to 5.0 from 3.0.#64
fassko merged 2 commits intoRxSwiftCommunity:masterfrom
h1d3mun3:master

Conversation

@h1d3mun3
Copy link
Copy Markdown

Updated Swift Language Version to 4.2 from 3.0.

Updated Swift Language Version to 4.2 from 3.0.
@pchelnikov
Copy link
Copy Markdown

What about Swift 5.0?

@h1d3mun3
Copy link
Copy Markdown
Author

@pchelnikov Thanks for comment!

I update Swift to 4.2 from 3.0.
But now, I think had better updated to 4.0.

Because, current RxSwift is supported Swift 4.0.

What do you think about this?

@fassko
Copy link
Copy Markdown
Member

fassko commented Mar 29, 2019

There is .swift-version file which has 4.2 but with new Cocoapods this is being deprecated and can be removed maybe with this PR?

For backward compatibility I would make tag for 4.2 and bump version to 5.0.

@h1d3mun3
Copy link
Copy Markdown
Author

@fassko Thanks for comments!

Unfortunately I'm not sure about a Cocoapods, so i would like to fix that problem with different PR.

For backward compatibility I would make tag for 4.2 and bump version to 5.0.

I am a bit confused. (I'm so so sorry.)

Does it mean that update swift version to 5.0 with this PR? 🤔

@fassko
Copy link
Copy Markdown
Member

fassko commented Mar 29, 2019

Sorry @h1d3mun3-74k4h45h1

I will merge this in coming future (right now I'm a bit busy) and do the rest then. I just don't want to merge this now because things I mentioned I need to do after that right away.

If you need this version, just point to your branch in Podfile and use it.

@h1d3mun3
Copy link
Copy Markdown
Author

@fassko Oh I get it! Understood!

@RafaelPlantard
Copy link
Copy Markdown
Contributor

Let's upgrade to 5.0? Now RxSwift also supports Swift 5.0

@h1d3mun3
Copy link
Copy Markdown
Author

h1d3mun3 commented Apr 3, 2019

@RafaelPlantard Thank you for information! Make it Swift5!

@h1d3mun3 h1d3mun3 changed the title Updated Swift Language Version to 4.2 from 3.0. Updated Swift to 5.0 from 3.0. Apr 3, 2019
@tomokisun
Copy link
Copy Markdown

Hello
Do not merge this PR?

@fassko fassko merged commit 837f162 into RxSwiftCommunity:master May 2, 2019
@rxswiftcommunity
Copy link
Copy Markdown

Thanks a lot for contributing @h1d3mun3-74k4h45h1! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants