Skip to content

Conversation

@farshadtx
Copy link
Contributor

No description provided.

@rxswiftcommunity
Copy link

rxswiftcommunity bot commented Jun 28, 2019

Warnings
⚠️

It looks like code was changed without adding anything to the Changelog. If this is a trivial PR that doesn't need a changelog, add #trivial to the PR title or body.

Thanks a lot for contributing @farshadtx! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@farshadtx farshadtx force-pushed the chores/update-rx-swift branch from f183c6c to 972ccea Compare June 28, 2019 17:32
@codecov-io
Copy link

codecov-io commented Jun 28, 2019

Codecov Report

Merging #20 into master will increase coverage by 2.02%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   92.71%   94.73%   +2.02%     
==========================================
  Files           4        4              
  Lines         247      247              
==========================================
+ Hits          229      234       +5     
+ Misses         18       13       -5
Impacted Files Coverage Δ
Source/Common/ActivityIndicator.swift 100% <100%> (ø) ⬆️
Tests/TwoWayBindingTests.swift 100% <100%> (ø) ⬆️
Source/iOS/TwoWayBinding.swift 76.36% <92.3%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfa7b3...e41a59e. Read the comment docs.

@farshadtx farshadtx changed the title Update RxSwift to 5.0 Update RxSwift to latest version (5.0) Jun 28, 2019
@farshadtx farshadtx mentioned this pull request Jul 11, 2019
@farshadtx
Copy link
Contributor Author

@freak4pc can you help on this?

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One note and a few renames. Thanks!

@farshadtx farshadtx force-pushed the chores/update-rx-swift branch from 972ccea to e41a59e Compare July 11, 2019 20:31
Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@freak4pc freak4pc merged commit a3e91fb into RxSwiftCommunity:master Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants