Potential fix for code scanning alert no. 1: Workflow does not contain permissions#256
Merged
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/obsidianforensics/hindsight/security/code-scanning/1
In general, the fix is to add an explicit
permissionsblock that grants only the minimal scopes needed to run the release drafter workflow. This can be done at the top level of the workflow (applying to all jobs) or specifically under theupdate_release_draftjob. Therelease-drafteraction needs to read repository contents and metadata and to update or create GitHub Releases, which requirescontents: write. Other scopes (like fullpull-requestsorissueswrite access) are not strictly necessary for basic operation and can remain at their default (implicitreadwhen unspecified in a job with an explicitpermissionsblock).The single best minimal change here is to add a
permissionsblock to theupdate_release_draftjob, right underruns-on: ubuntu-latest. This keeps the change tightly scoped to this job, documents what it needs, and avoids altering behavior of any other workflows. The block should grantcontents: writeand set all other implicit permissions tononeby virtue of not granting them (GitHub treats unspecified scopes under an explicitpermissionsasnone, except for a couple of impliedreadbehaviors which are limited). No imports or additional methods are needed; this is a pure YAML configuration change within.github/workflows/release-drafter.yml.Suggested fixes powered by Copilot Autofix. Review carefully before merging.