feat(dlssnr): localize effect parameter labels - #16
Merged
Conversation
Effect parameter labels now resolve through the app's resource system using the key ScalingModes_EffectParam_<effect>_<param>. Languages without a translation fall back to the label defined in the effect file, so non-Chinese languages keep the original English labels. Added zh-Hans and zh-Hant translations for all 12 DLSSNR AI Filter parameters.
The labels existed only in zh-Hans/zh-Hant resources, leaving no default-language candidate and triggering PRI263 warnings; lookups from non-Chinese languages could throw. Add the original English labels as the en-US default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(dlssnr): localize effect parameter labels
Summary
Localize the DLSSNR AI Filter parameter labels shown in the scaling-mode effect settings, following the app language setting.
ScalingModes_EffectParam_<effect>_<param>(\replaced with_).The mechanism is generic: future effect parameter translations only need new resource entries, no C++ changes.
Testing
EnableDLSSNR=true(NGX SDK headers/libs from NVIDIA/DLSS) passes.