SapMachine #2109: Linux: Configuration of glibc malloc arenas should be possible #2110
Conversation
|
Hello @TheRealMDoerr, I'm sorry, this pull request doesn't meet the expectations. The pull request description has an invalid format. Please have a look at https://github.com/SAP/SapMachine/wiki/Formal-Requirements-of-Pull-Requests . |
There was a problem hiding this comment.
From my current investigation the malloc arena is 64MB on Linux x86_64.
There was a problem hiding this comment.
Seems this can vary, based on distro, glibc version, CPUs etc. etc. .
| \ | ||
| /* SapMachine 2025-11-24: Configurable limit of malloc arenas */ \ | ||
| product(int, GlibcMallocArenas, 1, \ | ||
| "Limit glibc malloc arenas, 0 means use OS default") \ |
There was a problem hiding this comment.
maybe add - 'our default is only one arena for minimum memory use.'
|
Thanks for reviewing! I've improved the description and the comment. |
|
retest this please |
|
Hello @TheRealMDoerr, this pull request fulfills all formal requirements. |
RealCLanger
left a comment
RealCLanger
left a comment
There was a problem hiding this comment.
LGTM. Please squash when merging.
…be possible (#2110) Introduction of switch "GlibcMallocArenas" with default value 1 for minimized memory utilization.
…be possible (#2110) Introduction of switch "GlibcMallocArenas" with default value 1 for minimized memory utilization.
Make glibc malloc arenas configurable, but use only 1 by default. See Issue below.
fixes #2109