Port Changes from Main to Release-4 #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slight adaptations of the code to the changed API. The additional test dependency is required as the original dependency is no longer transitive but "provided". Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Bumps org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-version: 3.18.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit a5312b2)
Signed-off-by: Karsten Schnitter <k.schnitter@sap.com> (cherry picked from commit edca148)
KarstenSchnitter
requested review from
bennygoerzig,
christiand93,
juergen-walter and
nicklas-dohrn
Member
|
From the description of the change from "Upgrade OTel SDK Dependency" https://github.com/SAP/cf-java-logging-support/pull/212/files, i cannot understande the change from |
Member
|
Would be nice if you could cherry-pick with a reference to the original commit, as this would also link the original PRs git cherry-pick |
juergen-walter
approved these changes
Oct 24, 2025
KarstenSchnitter
added a commit
that referenced
this pull request
Dec 3, 2025
#221 upgraded the OpenTelemetry SDK version. This changed the construction of the `DefaultConfigProperties` in an incompatible way. This lead to ignored configuration properties. This change ensures, that the original behavior is restored. The now used method reads the environment variables and system properties again. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
KarstenSchnitter
added a commit
that referenced
this pull request
Dec 3, 2025
#221 upgraded the OpenTelemetry SDK version. This changed the construction of the `DefaultConfigProperties` in an incompatible way. This lead to ignored configuration properties. This change ensures, that the original behavior is restored. The now used method reads the environment variables and system properties again. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the last cherry-pick to port changes from the main branch to the release-4.
After this change the rc1 can be created and uploaded.