Fix Configuration parsing #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#221 upgraded the OpenTelemetry SDK version. This changed the construction of the `DefaultConfigProperties` in an incompatible way. This lead to ignored configuration properties. This change ensures, that the original behavior is restored. The now used method reads the environment variables and system properties again. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
KarstenSchnitter
added a commit
that referenced
this pull request
Dec 3, 2025
cherry-pick #95392fd from PR #312 Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
bennygoerzig
approved these changes
Dec 3, 2025
juergen-walter
approved these changes
Dec 3, 2025
KarstenSchnitter
added a commit
that referenced
this pull request
Dec 3, 2025
cherry-pick #95392fd from PR #312 Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#221 upgraded the OpenTelemetry SDK version. This changed the construction of the
DefaultConfigPropertiesin an incompatible way. This led to ignored configuration properties. This change ensures, that the original behavior is restored.The now used method reads the environment variables and system properties again.