Skip to content

feat(sdk-review): batch 2/6 — test harness + fixtures#203

Merged
tiagoek merged 1 commit into
feat/sdk-review-skillfrom
feat/sdk-review-batch-2
Jul 7, 2026
Merged

feat(sdk-review): batch 2/6 — test harness + fixtures#203
tiagoek merged 1 commit into
feat/sdk-review-skillfrom
feat/sdk-review-batch-2

Conversation

@tiagoek

@tiagoek tiagoek commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

Adds 57 bats tests (test_smoke.bats, test_extended.bats) and 6 fixture diffs. Tests exercise the libs from batch 1 end-to-end. Check-specific fixtures land alongside their checks in batches 3-5.

This is part 2 of 6 in the incremental delivery of the SDK Module Review skill (AFSDK-3937).

Each sub-PR is scoped to be reviewable in ≤ 30 minutes and satisfies these isolation criteria:

  • Compiles alone (shellcheck / ruff pass)
  • Testable alone (bats/pytest pass on top of the prior batches)
  • Revert-safe (prior batches keep working if this one is reverted)
  • No breaking changes for subsequent batches

Related Issue

Internal tracking: AFSDK-3937

Type of Change

  • New feature (non-breaking change that adds functionality)

How to Test

git checkout feat/sdk-review-batch-2
bats tests/sdk-review/          # if applicable to this batch
shellcheck -x --severity=error .claude/scripts/**/*.sh

Batch progression

After all 6 batches are merged into feat/sdk-review-skill, a final cosmetic PR will merge feat/sdk-review-skill into main.

Checklist

  • Follows Conventional Commits
  • Isolated (see criteria above)
  • No sensitive information (fixture strings are placeholder patterns, not real credentials)

@tiagoek tiagoek changed the base branch from feat/sdk-review-skill to feat/sdk-review-batch-1 July 6, 2026 15:06
@tiagoek tiagoek force-pushed the feat/sdk-review-batch-2 branch from be587a4 to f4a2abd Compare July 6, 2026 15:17
@tiagoek tiagoek force-pushed the feat/sdk-review-batch-1 branch from 26b12e1 to f88fb3b Compare July 6, 2026 15:46
@tiagoek tiagoek force-pushed the feat/sdk-review-batch-2 branch 2 times, most recently from 49f7089 to 0c8b36f Compare July 6, 2026 15:59
Adds 57 bats tests + 6 fixture diffs. Tests exercise the libs from batch 1.
All check-specific tests use conditional skip guards so tests skip cleanly
when scripts are not yet present in the current batch.

Part 2 of 6. Ref: AFSDK-3937
@tiagoek tiagoek force-pushed the feat/sdk-review-batch-2 branch from 0c8b36f to 699d0e1 Compare July 6, 2026 20:13
Base automatically changed from feat/sdk-review-batch-1 to feat/sdk-review-skill July 7, 2026 15:07
@tiagoek tiagoek merged commit 699d0e1 into feat/sdk-review-skill Jul 7, 2026
3 checks passed
@tiagoek tiagoek deleted the feat/sdk-review-batch-2 branch July 7, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant