feat(sdk-review): batch 2/6 — test harness + fixtures#203
Merged
Conversation
be587a4 to
f4a2abd
Compare
26b12e1 to
f88fb3b
Compare
49f7089 to
0c8b36f
Compare
Adds 57 bats tests + 6 fixture diffs. Tests exercise the libs from batch 1. All check-specific tests use conditional skip guards so tests skip cleanly when scripts are not yet present in the current batch. Part 2 of 6. Ref: AFSDK-3937
0c8b36f to
699d0e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds 57 bats tests (
test_smoke.bats,test_extended.bats) and 6 fixture diffs. Tests exercise the libs from batch 1 end-to-end. Check-specific fixtures land alongside their checks in batches 3-5.This is part 2 of 6 in the incremental delivery of the SDK Module Review skill (AFSDK-3937).
Each sub-PR is scoped to be reviewable in ≤ 30 minutes and satisfies these isolation criteria:
Related Issue
Internal tracking: AFSDK-3937
Type of Change
How to Test
Batch progression
After all 6 batches are merged into
feat/sdk-review-skill, a final cosmetic PR will mergefeat/sdk-review-skillintomain.Checklist