feat: adapt secret resolver for custumization#210
Closed
betinacosta wants to merge 5 commits into
Closed
Conversation
NicoleMGomes
reviewed
Jul 6, 2026
| protocol — no inheritance required. | ||
| """ | ||
|
|
||
| def resolve(self, module: str, instance: str, target: Any) -> None: |
Contributor
There was a problem hiding this comment.
We should have some resolve that directly gets a path or env var name and resolve it to offer more flexibility. We should also have default values for what managed runtime exposes.
NicoleMGomes
reviewed
Jul 6, 2026
| """Load secrets from environment variables.""" | ||
| normalized_module = module.replace("-", "_") | ||
| normalized_instance = instance.replace("-", "_") | ||
| _load_from_env( |
Contributor
There was a problem hiding this comment.
Maybe split each resolver in a file and have whole resolution logic there. So reimplement _load_from_env here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a clear description of your changes here.
Related Issue
Closes #<issue_number>
(Link to the GitHub issue this PR addresses)
Type of Change
Please check the relevant option:
How to Test
Describe how reviewers can test your changes:
Checklist
Before submitting your PR, please review and check the following:
Breaking Changes
If this PR introduces breaking changes, please describe:
Additional Notes
Add any additional context, screenshots, or information that would help reviewers.