feat: add identity attributes to OTLP logs - #308
Merged
Conversation
LucasAlvesSoares
marked this pull request as ready for review
September 4, 2026 17:39
jeanscherf
reviewed
Sep 4, 2026
# Conflicts: # pyproject.toml # uv.lock
jeanscherf
previously approved these changes
Sep 4, 2026
jeanscherf
left a comment
Member
There was a problem hiding this comment.
LGTM.
Added one comment.
Also maybe it's worth updating the telemetry user-guide in the logging part. That we now inject these attribs as well.
jeanscherf
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enriches OTel log records with
sap.tenancy.tenant_idanduser.idA new
IdentityLogFilter(incore/telemetry/log_filters/identity.py) is installed on theLoggingHandlercreated bysetup_log_provider().Type of Change
Please check the relevant option:
How to Test
auto_instrument()andStarletteIASTelemetryMiddleware, send a request with a valid IAS Bearer token and confirm that exported OTel log records carrysap.tenancy.tenant_idanduser.idmatching the JWT claims.Checklist
Before submitting your PR, please review and check the following:
Additional Notes
The filter is intentionally kept out of
_provider.pyand placed inlog_filters/identity.py, mirroring thespan_processors/layout. Adding a new log filter in future requires only a new file in that folder and one import.